fix(language-service): Lazily instantiate MetadataResolver #32631
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyliau
added
area: language-service
ayazhafiz
requested changes
Sep 12, 2019
kyliau
force-pushed
the
lazy_instantiation
branch
2 times, most recently
from
eea613c
to
f0cf40b
Compare
The instantiation of the resolver also requires instantiation of the StaticReflector, and the latter requires resolution of core Angular symbols. Module resolution should not be done during instantiation to avoid potential cyclic dependency between the plugin and the containing Project, so the Singleton pattern is used to create the resolver.
kyliau
force-pushed
the
lazy_instantiation
branch
from
f0cf40b
to
17267c0
Compare
ayazhafiz
approved these changes
Sep 12, 2019
arnehoek
pushed a commit
to arnehoek/angular
that referenced
this pull request
Sep 26, 2019
…2631) The instantiation of the resolver also requires instantiation of the StaticReflector, and the latter requires resolution of core Angular symbols. Module resolution should not be done during instantiation to avoid potential cyclic dependency between the plugin and the containing Project, so the Singleton pattern is used to create the resolver. PR Close angular#32631
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The instantiation of the resolver also requires instantiation of the
StaticReflector, and the latter requires resolution of core Angular symbols.
Module resolution should not be done during instantiation to avoid potential
cyclic dependency between the plugin and the containing Project, so the
Singleton pattern is used to create the resolver.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information